Issue 6310009: Enable compilation of very simple functions in x64 crankshaft....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6310009: Enable compilation of very simple functions in x64 crankshaft.... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Enable compilation of very simple functions in x64 crankshaft. This change includes support for safepointtables and adding deoptimization info (but not for deoptimizing). Implemented crankshaft functions: CallCode GenerateSafepointTable RegisterEnvironmentForDeoptimization EmitGoto This change allows us to compile very simple functions with crankshaft: An empty function A function returning a constant. A function returning a parameter. There is 6 disabled tests that require us to be able to deoptimize which is currently not supported. Committed: http://code.google.com/p/v8/source/detail?r=6350

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -9 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	2 chunks	+4 lines, -2 lines	2 comments	Download
M	src/x64/frames-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	4 chunks	+58 lines, -5 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 11 months ago (2011-01-17 13:06:54 UTC) #2

LGTM.

http://codereview.chromium.org/6310009/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

http://codereview.chromium.org/6310009/diff/1/src/x64/deoptimizer-x64.cc#newc...
src/x64/deoptimizer-x64.cc:44: // UNIMPLEMTED, for now just return.
UNIMPLEMENTED

http://codereview.chromium.org/6310009/diff/1/src/x64/deoptimizer-x64.cc#newc...
src/x64/deoptimizer-x64.cc:73: return;
ditto

Expand Messages | Collapse Messages