chrome/test/data/instant/search.html - Issue 6310003: Support specified JSON as argument to setSuggestions().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/instant/search.html

Issue 6310003: Support specified JSON as argument to setSuggestions(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <h1>Instant</h1>	3 <h1>Instant</h1>

4 <div id=log></div>	4 <div id=log></div>

5 <script>	5 <script>

6 window.chrome.sv = true;	6 window.chrome.sv = true;

7	7

8 window.onsubmitcalls = 0;	8 window.onsubmitcalls = 0;

9 window.onchangecalls = 0;	9 window.onchangecalls = 0;

10 window.oncancelcalls = 0;	10 window.oncancelcalls = 0;

11 window.onresizecalls = 0;	11 window.onresizecalls = 0;

12	12

13 var searchBox = window.chrome.searchBox \|\| {};	13 var searchBox = window.chrome.searchBox \|\| {};

14	14

15 window.beforeLoadSearchBox = {};	15 window.beforeLoadSearchBox = {};

16 for (var prop in searchBox) window.beforeLoadSearchBox[prop] = searchBox[prop];	16 for (var prop in searchBox) window.beforeLoadSearchBox[prop] = searchBox[prop];

17	17

	18 window.setSuggestionsArgument = ["abcdef"];
	sky 2011/01/13 22:37:46 Doesn't this need to be map with suggestions: cont Doesn't this need to be map with suggestions: containing an array of maps? tonyg 2011/01/13 23:07:50 An array of strings is the old format (which conti Show quoted text On 2011/01/13 22:37:46, sky wrote: > Doesn't this need to be map with suggestions: containing an array of maps? An array of strings is the old format (which continues to be supported). But it does seem better to have the new one here. Fixed.
	19

18 window.chrome.searchBox.onsubmit = function() {	20 window.chrome.searchBox.onsubmit = function() {

19 searchBox.setSuggestions(["abcdef"]);	21 searchBox.setSuggestions(setSuggestionsArgument);

20 window.onsubmitcalls++;	22 window.onsubmitcalls++;

21 };	23 };

22	24

23 window.chrome.searchBox.onchange = function() {	25 window.chrome.searchBox.onchange = function() {

24 searchBox.setSuggestions(["abcdef"]);	26 searchBox.setSuggestions(setSuggestionsArgument);

25 window.onchangecalls++;	27 window.onchangecalls++;

26 };	28 };

27	29

28 window.chrome.searchBox.oncancel = function() {	30 window.chrome.searchBox.oncancel = function() {

29 searchBox.setSuggestions(["abcdef"]);	31 searchBox.setSuggestions(setSuggestionsArgument);

30 window.oncancelcalls++;	32 window.oncancelcalls++;

31 };	33 };

32	34

33 window.chrome.searchBox.onresize = function() {	35 window.chrome.searchBox.onresize = function() {

34 window.onresizecalls++;	36 window.onresizecalls++;

35 };	37 };

36 </script>	38 </script>

37 </body>	39 </body>

38 </html>	40 </html>

OLD	NEW

« chrome/renderer/searchbox_extension.cc ('K') | « chrome/renderer/searchbox_extension.cc ('k') | no next file » | no next file with comments »