Issue 6310002: Support accDoDefaultAction for NativeButton in ViewAccessibility....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6310002: Support accDoDefaultAction for NativeButton in ViewAccessibility.... (Closed)

Created:
9 years, 11 months ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, kkania

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support accDoDefaultAction for NativeButton in ViewAccessibility. BUG=none TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71512

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	views/accessibility/view_accessibility.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	views/accessibility/view_accessibility.cc	View		3 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

9 years, 11 months ago (2011-01-14 18:22:07 UTC) #3

LGTM.

If this is the only case we end up deciding to handle, this is good.

If we need to implement actions for 2 or more view types, I'd suggest we add a
new method to view.h called performDefaultAction and then override it in
NativeButton and other classes.

Expand Messages | Collapse Messages