Refactoring; switch the |filter| parameter into something that is more amenab...

chrome/browser/download/save_package.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/save_package.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 977 matching lines @@
   file_util::ReplaceIllegalCharacters(&file_name, L' ');
   TrimWhitespace(file_name, TRIM_ALL, &file_name);
   FilePath suggest_name = FilePath::FromWStringHack(save_file_path.GetValue());
   suggest_name = suggest_name.Append(FilePath::FromWStringHack(file_name));
 
   return suggest_name;
 }
 
 void SavePackage::GetSaveInfo() {
   // Use "Web Page, Complete" option as default choice of saving page.
-  int filter_index = 2;
-  std::wstring filter;
+  int file_type_index = 2;
+  SelectFileDialog::FileTypeInfo file_type_info;
   FilePath::StringType default_extension;
   FilePath title =
       FilePath::FromWStringHack(UTF16ToWideHack(web_contents_->GetTitle()));
   FilePath suggested_path =
       GetSuggestNameForSaveAs(web_contents_->profile()->GetPrefs(), title);
 
   SavePackageParam* save_params =
       new SavePackageParam(web_contents_->contents_mime_type());
 
   // If the contents can not be saved as complete-HTML, do not show the
   // file filters.
   if (CanSaveAsComplete(save_params->current_tab_mime_type)) {
-    filter = l10n_util::GetString(IDS_SAVE_PAGE_FILTER);
-    filter.resize(filter.size() + 2);
-    filter[filter.size() - 1] = L'\0';
-    filter[filter.size() - 2] = L'\0';
+    file_type_info.extensions.resize(2);
+    file_type_info.extensions[0].push_back(FILE_PATH_LITERAL("htm"));
+    file_type_info.extension_description_overrides.push_back(
+        WideToUTF16(l10n_util::GetString(IDS_SAVE_PAGE_DESC_HTML_ONLY)));
+    file_type_info.extensions[1].push_back(FILE_PATH_LITERAL("htm"));
+    file_type_info.extension_description_overrides.push_back(
+        WideToUTF16(l10n_util::GetString(IDS_SAVE_PAGE_DESC_COMPLETE)));
+    file_type_info.include_all_files = false;
     default_extension = FILE_PATH_LITERAL("htm");
   } else {
-#if defined(OS_WIN)
-    filter = win_util::GetFileFilterFromPath(suggested_path.ToWStringHack());
-#else
-    // TODO(port): implement this.
-    NOTIMPLEMENTED();
-#endif
-    filter_index = 1;
+    file_type_info.extensions.resize(1);
+    file_type_info.extensions[0].push_back(suggested_path.Extension());
+    file_type_info.include_all_files = true;
+    file_type_index = 1;
   }
 
-
 #if defined(OS_LINUX) || defined(OS_WIN)
   if (g_should_prompt_for_filename) {
     if (!select_file_dialog_.get())
       select_file_dialog_ = SelectFileDialog::Create(this);
     select_file_dialog_->SelectFile(SelectFileDialog::SELECT_SAVEAS_FILE,
                                     string16(),
                                     suggested_path,
-                                    filter,
-                                    filter_index,
+                                    &file_type_info,
+                                    file_type_index,
                                     default_extension,
                                     platform_util::GetTopLevel(
                                         web_contents_->GetNativeView()),
                                     save_params);
   } else
 #endif  // defined(OS_LINUX) || defined(OS_WIN)
   {
     // Just use 'suggested_path' instead of opening the dialog prompt.
-    ContinueSave(save_params, suggested_path, filter_index);
+    ContinueSave(save_params, suggested_path, file_type_index);
     delete save_params;
   }
 }
 
 // Called after the save file dialog box returns.
 void SavePackage::ContinueSave(SavePackageParam* param,
                                const FilePath& final_name,
                                int index) {
   // Ensure the filename is safe.
   param->saved_main_file_path = final_name;
@@ skipping 89 matching lines @@
                                int index, void* params) {
   SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params);
   ContinueSave(save_params, path, index);
   delete save_params;
 }
 
 void SavePackage::FileSelectionCanceled(void* params) {
   SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params);
   delete save_params;
 }