build/util/lastchange.py - Issue 6308016: lastchange: don't use git rev-parse output when it fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/util/lastchange.py

Issue 6308016: lastchange: don't use git rev-parse output when it fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/util/lastchange.py

diff --git a/build/util/lastchange.py b/build/util/lastchange.py

index 8376b543802738a56224da75b3874370851265e2..7c34fbea3b41f50014c36858b12c2613d9cefc50 100755

--- a/build/util/lastchange.py

+++ b/build/util/lastchange.py

@@ -41,7 +41,10 @@ def FetchGitRevision(directory):

cwd=directory)

except OSError:

return None

- return VersionInfo('git', 'git', proc.stdout.read().strip()[:7])

+ output = proc.communicate()[0].strip()

+ if proc.returncode == 0 and output:

+ return VersionInfo('git', 'git', output[:7])

+ return None

def FetchSVNRevision(directory):

« no previous file with comments | « no previous file | no next file » | no next file with comments »