Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 6308007: WIP Chromite supporting "LEGACY" mode, as requested by Anush. (Closed)

Created:
9 years, 11 months ago by diandersAtChromium
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

WIP Chromite supporting "LEGACY" mode, as requested by Anush. This version of chromite supports the following features: 1. Can be run from inside or outside the chroot. 2. CWD can be anything when chromite is run. 3. Current commands are build, clean, distclean, ebuild, emerge, equery, portageq, shell, workon. 4. Build spec files can be named on command line using any substring. 5. Build commands can be named on command line using any prefix. 6. Menu driven for easy discovery. 7. Chroot specs can be specified for any command with --chroot, which must be the first thing on the command line (so it's not interpreted as the arg to sub commands). By default, the 'chroot.spec' is used. See http://codereview.chromium.org/6005004 for history. This is a separate CL, since Anush has requested this be checked into the new 'chromite' repo. This CL has the minor change that a few paths are adapted to chromite's new location. Future checkins will: - Add wrapper scripts for inside and outside the chroot so that we can put chromite in the path - Add more unit tests - Address some of the TODOs in the file. BUG=chromium-os:10556 TEST=Ran chromite_unittest.py; played w/ various commands. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f0c7395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1586 lines, -122 lines) Patch
D chromite View 1 chunk +0 lines, -59 lines 0 comments Download
A chromite.py View 1 chunk +1065 lines, -0 lines 0 comments Download
A chromite_unittest.py View 1 chunk +389 lines, -0 lines 0 comments Download
A specs/build/_defaults View 1 chunk +39 lines, -0 lines 0 comments Download
A specs/build/tegra2_seaboard.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/build/x86-agz.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/build/x86-dogfood.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/build/x86-generic.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/build/x86-mario.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/build/x86-pineview.spec View 1 chunk +10 lines, -0 lines 0 comments Download
A specs/chroot/_defaults View 1 chunk +28 lines, -0 lines 0 comments Download
A specs/chroot/chroot.spec View 1 chunk +5 lines, -0 lines 0 comments Download
D specs/x86-generic.spec View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
diandersAtChromium
9 years, 11 months ago (2011-01-18 21:45:33 UTC) #1
I will be committing this based on LGTM and reviews in:
  http://codereview.chromium.org/6005004

Powered by Google App Engine
This is Rietveld 408576698