Cleanup: remove unused internet and system pages for chrome os options.

Cleanup: remove unused internet and system pages for chrome os options.

These are now unused because of the migration to DOMUI options.  This is a continuation of cleanup done in http://codereview.chromium.org/6336005/

BUG=chromium-os:8307
TEST=ran on linux and netbook, unit tests passed

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73432

[satorux1, 2011-01-28 06:03:49]

http://codereview.chromium.org/6307019/diff/1/chrome/browser/chromeos/options...
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/6307019/diff/1/chrome/browser/chromeos/options...
chrome/browser/chromeos/options/options_window_view.cc:1: // Copyright (c) 2011
The Chromium Authors. All rights reserved.
I think you can remove this file as well.

[falken, 2011-01-28 07:55:14]

Thanks for the comment. I've removed options_window_view as well.  This involved
some more modifications such as to
chrome/browser/ui/gtk/options/options_window_gtk.cc, but it compiles and seems
to work on netbook and Linux.  Also, unit tests pass.

http://codereview.chromium.org/6307019/diff/1/chrome/browser/chromeos/options...
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/6307019/diff/1/chrome/browser/chromeos/options...
chrome/browser/chromeos/options/options_window_view.cc:1: // Copyright (c) 2011
The Chromium Authors. All rights reserved.
On 2011/01/28 06:03:49, satorux1 wrote:
> I think you can remove this file as well.

Done.

[falken, 2011-01-31 01:08:14]

Copying chocobo@'s comment on http://codereview.chromium.org/6336005/ to here:

On 2011/01/28 18:14:12, Charlie Lee wrote:
> LGTM
> 
> Looks like we should remove system_page_view also. And remove the
> kDisableTabbedOptions switch.

[satorux1, 2011-01-31 09:24:14]

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:41: #if defined(OS_CHROMEOS)
I think you can remove code in OS_CHROMEOS from this file.

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:145: #if defined(OS_CHROMEOS)
ditto.

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:1006: #if defined(OS_CHROMEOS)
I think you can delete the entire OS_CHROMEOS block.

[Charlie Lee, 2011-01-31 18:41:09]

LGTM

[falken, 2011-02-01 05:21:01]

I've uploaded a new patch that removes kDisabledTabbedOptions and the ifdef
OS_CHROMEOS code in gtk_util.cc.

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:41: #if defined(OS_CHROMEOS)
On 2011/01/31 09:24:14, satorux1 wrote:
> I think you can remove code in OS_CHROMEOS from this file.

Done.

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:145: #if defined(OS_CHROMEOS)
On 2011/01/31 09:24:14, satorux1 wrote:
> ditto.

Done.

http://codereview.chromium.org/6307019/diff/5001/chrome/browser/ui/gtk/gtk_ut...
chrome/browser/ui/gtk/gtk_util.cc:1006: #if defined(OS_CHROMEOS)
On 2011/01/31 09:24:14, satorux1 wrote:
> I think you can delete the entire OS_CHROMEOS block.

Done.

[falken, 2011-02-01 05:58:37]

Sorry for the frequent updates.  satorux says we should keep
kDisableTabbedOptions for now, so I've restored it in the latest patch.

[tfarina, 2011-02-01 11:45:17]

On 2011/02/01 05:58:37, falken wrote:
> Sorry for the frequent updates.  satorux says we should keep
> kDisableTabbedOptions for now, so I've restored it in the latest patch.

Could you remove settings_page_view.[cc,h] too?

If I'm not wrong "git gs SettingsPageView" shows that there aren't users of it
after applying this patch.

[Charlie Lee, 2011-02-02 02:37:06]

LGTM

On 2011/02/01 11:45:17, tfarina wrote:
> On 2011/02/01 05:58:37, falken wrote:
> > Sorry for the frequent updates.  satorux says we should keep
> > kDisableTabbedOptions for now, so I've restored it in the latest patch.
> 
> Could you remove settings_page_view.[cc,h] too?
> 
> If I'm not wrong "git gs SettingsPageView" shows that there aren't users of it
> after applying this patch.

[falken, 2011-02-02 03:21:57]

On 2011/02/01 11:45:17, tfarina wrote:
> On 2011/02/01 05:58:37, falken wrote:
> > Sorry for the frequent updates.  satorux says we should keep
> > kDisableTabbedOptions for now, so I've restored it in the latest patch.
> 
> Could you remove settings_page_view.[cc,h] too?
> 
> If I'm not wrong "git gs SettingsPageView" shows that there aren't users of it
> after applying this patch.

Done.

[satorux1, 2011-02-02 03:29:49]

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/gtk_u...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/gtk_u...
chrome/browser/ui/gtk/gtk_util.cc:29: #include
"chrome/browser/ui/gtk/browser_window_gtk.h"
Do we need to add this? Otherwise, please remove it.

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/optio...
File chrome/browser/ui/gtk/options/content_page_gtk.cc (right):

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/optio...
chrome/browser/ui/gtk/options/content_page_gtk.cc:69: #if !defined(OS_CHROMEOS)
I think you can remove the line, and the corresponding #endif. Please also check
OS_CHROMEOS in this file.

[falken, 2011-02-02 04:59:34]

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/gtk_u...
File chrome/browser/ui/gtk/gtk_util.cc (right):

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/gtk_u...
chrome/browser/ui/gtk/gtk_util.cc:29: #include
"chrome/browser/ui/gtk/browser_window_gtk.h"
On 2011/02/02 03:29:49, satorux1 wrote:
> Do we need to add this? Otherwise, please remove it.

Yes, it's still needed.  I just moved it from the #else of the #ifdef that was
removed.

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/optio...
File chrome/browser/ui/gtk/options/content_page_gtk.cc (right):

http://codereview.chromium.org/6307019/diff/18001/chrome/browser/ui/gtk/optio...
chrome/browser/ui/gtk/options/content_page_gtk.cc:69: #if !defined(OS_CHROMEOS)
On 2011/02/02 03:29:49, satorux1 wrote:
> I think you can remove the line, and the corresponding #endif. Please also
check
> OS_CHROMEOS in this file.

Done.

[satorux1, 2011-02-02 05:30:07]

LGTM