Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 6307018: Remove obsolete files from 'sources'. This causes needless work on increment... (Closed)

Created:
9 years, 11 months ago by jeanluc1
Modified:
9 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google, Sergey Ulanov, amit, apatrick_chromium, dmac, darin-cc_chromium.org, awong, garykac, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove obsolete files from 'sources'. This causes needless work on incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -43 lines) Patch
M app/app_base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/allocator/allocator.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame.gyp View 10 chunks +11 lines, -14 lines 0 comments Download
M chrome_frame/chrome_frame_launcher.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/skia.gyp View 6 chunks +4 lines, -5 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M third_party/libxml/libxml.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jeanluc1
9 years, 11 months ago (2011-01-27 23:47:03 UTC) #1
bradn
9 years, 11 months ago (2011-01-27 23:52:03 UTC) #2
LGTM, though wait for the tryboys.

Powered by Google App Engine
This is Rietveld 408576698