Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6307015: Fix a bug where we were showing a wrong language name on the OOBE screen. (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Dmitry Polukhin
Visibility:
Public.

Description

Fix a bug where we were showing a wrong language name on the OOBE screen. The OOBE screen is by defaut shown in English, but is also shown in a different language if "initial_locale" value is set in /mnt/partner_partition/etc/startup_manifest.json In this case, the default language name of the language selection menu should be the one specified by "initial_locale". However, we were always showing English before this fix. BUG=chromium-os:11345 TEST=See the instruction at crosbug.com/11345 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72762

Patch Set 1 #

Patch Set 2 : add helpful comments #

Total comments: 2

Patch Set 3 : remove unnecessary code #

Patch Set 4 : reorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
9 years, 11 months ago (2011-01-26 10:55:11 UTC) #1
Nikita (slow)
LGTM http://codereview.chromium.org/6307015/diff/2001/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/6307015/diff/2001/chrome/browser/chromeos/login/wizard_controller.cc#newcode984 chrome/browser/chromeos/login/wizard_controller.cc:984: chromeos::LanguageSwitchMenu::SwitchLanguage(locale); SwitchLanguage basically does the same - Reload ...
9 years, 11 months ago (2011-01-26 12:25:48 UTC) #2
satorux1
9 years, 11 months ago (2011-01-26 14:03:05 UTC) #3
http://codereview.chromium.org/6307015/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/6307015/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_controller.cc:984:
chromeos::LanguageSwitchMenu::SwitchLanguage(locale);
On 2011/01/26 12:25:48, Nikita Kostylev wrote:
> SwitchLanguage basically does the same - Reload shared instance, switch
locale.
> I guess this call is not needed anymore.

I think you are right, and we seem to be doing the same thing twice. :)

I'll remove this code after testing it.

Powered by Google App Engine
This is Rietveld 408576698