Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 6307010: Use Signal Callback in Ambient Light Sensor (Closed)

Created:
9 years, 11 months ago by Benson Leung
Modified:
9 years, 7 months ago
Reviewers:
Simon Que
CC:
chromium-os-reviews_chromium.org, davidjames, Benson Leung, Sameer Nanda
Visibility:
Public.

Description

Use Signal Callback in Ambient Light Sensor Use the signal callback macro to clean up the ambient light sensor polling g_timeout callback. Change-Id: Ie2c4a5aaa0b8f57ec8be55939cfbcc6041005a62 Signed-off-by: Benson Leung <bleung@chromium.org>; Signed-off-by: Simon Que <sque@chromium.org>; BUG=chromium-os:7934 TEST=Built power manager. Tested that light sensor works as before. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d44134b

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review feedback #

Patch Set 3 : Added comments for ReadAls and Deffered Init. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M ambient_light_sensor.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M ambient_light_sensor.cc View 1 3 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benson Leung
9 years, 11 months ago (2011-01-21 20:12:44 UTC) #1
Simon Que
http://codereview.chromium.org/6307010/diff/1/ambient_light_sensor.cc File ambient_light_sensor.cc (right): http://codereview.chromium.org/6307010/diff/1/ambient_light_sensor.cc#newcode1 ambient_light_sensor.cc:1: // Copyright (c) 2010 The Chromium OS Authors. All ...
9 years, 11 months ago (2011-01-21 20:51:14 UTC) #2
Benson Leung
http://codereview.chromium.org/6307010/diff/1/ambient_light_sensor.cc File ambient_light_sensor.cc (right): http://codereview.chromium.org/6307010/diff/1/ambient_light_sensor.cc#newcode1 ambient_light_sensor.cc:1: // Copyright (c) 2010 The Chromium OS Authors. All ...
9 years, 11 months ago (2011-01-21 20:55:57 UTC) #3
Simon Que
9 years, 11 months ago (2011-01-21 22:52:45 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698