Issue 63067: Make the define of SKIA_HARFBUZZ and the link against harfbuzz.a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63067: Make the define of SKIA_HARFBUZZ and the link against harfbuzz.a... (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, Mark Mentovai

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the define of SKIA_HARFBUZZ and the link against harfbuzz.a part of the {direct,export}_dependent_settings in skia. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13268

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	skia/skia.gyp	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	webkit/webkit.gyp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 8 months ago (2009-04-07 16:51:32 UTC) #1

Since skia now defines SKIA_HARFBUZ, it should be part of
direct_dependent_settings so that components using skia get the definition
without having to define it by hand.  Ditto for export_dependent_settings of the
link against the harfbuzz library.

Let me know if I've misunderstood the build intent of harfbuzz.

mmentovai:  sanity check, please.

Expand Messages | Collapse Messages