Issue 63063: Add ../third_party/harfbuzz to all.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63063: Add ../third_party/harfbuzz to all.gyp. (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, M-A Ruel, Dean McNamee

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add ../third_party/harfbuzz to all.gyp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13252

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 8 months ago (2009-04-07 15:57:51 UTC) #1

In addition to following all.gyp convention, this works around a dependency
issue w/harfbuzz that was preventing all the harfbuzz*.scons files from getting
generated.  (The real fix needs to make things dependent on skia realize that
they now need harfbuzz, too.  Separate CL.)

Expand Messages | Collapse Messages