Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 63062: Timeout of os.system() in d8 was timing out too soon. (Closed)

Created:
11 years, 8 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Timeout of os.system() in d8 was timing out too soon. Committed: http://code.google.com/p/v8/source/detail?r=1711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/d8-posix.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 8 months ago (2009-04-07 13:35:54 UTC) #1
Kasper Lund
11 years, 8 months ago (2009-04-07 13:39:44 UTC) #2
LGTM. Seems like an improvement, although I have to say that the code seems
slightly complicated.

Powered by Google App Engine
This is Rietveld 408576698