Issue 63062: Timeout of os.system() in d8 was timing out too soon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63062: Timeout of os.system() in d8 was timing out too soon. (Closed)

Created:
11 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Timeout of os.system() in d8 was timing out too soon. Committed: http://code.google.com/p/v8/source/detail?r=1711

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/d8-posix.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Kasper Lund

11 years, 8 months ago (2009-04-07 13:39:44 UTC) #2

LGTM. Seems like an improvement, although I have to say that the code seems
slightly complicated.