Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/arm/lithium-arm.cc

Issue 6306014: Fix reintroduction of global variables that have been deleted. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: x64 LoadRoot and only check in lithium when needed Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/lithium-arm.cc
diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc
index ce3a66f9c3fce0953f6d80a701087e49cb3aa2ec..5045ab8763eb3e2a521a0fbeff7d97a4283b9631 100644
--- a/src/arm/lithium-arm.cc
+++ b/src/arm/lithium-arm.cc
@@ -1602,7 +1602,12 @@ LInstruction* LChunkBuilder::DoLoadGlobal(HLoadGlobal* instr) {
LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) {
- return new LStoreGlobal(UseRegisterAtStart(instr->value()));
+ LOperand* temp = instr->check_hole_value() ? TempRegister() : NULL;
Kevin Millikin (Chromium) 2011/01/27 07:56:07 OK, but since almost every line has to check the s
Mads Ager (chromium) 2011/01/27 08:33:36 Done.
+ LOperand* value = instr->check_hole_value()
+ ? UseRegister(instr->value())
+ : UseRegisterAtStart(instr->value());
+ LStoreGlobal* result = new LStoreGlobal(value, temp);
+ return instr->check_hole_value() ? AssignEnvironment(result) : result;
}
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698