src/hydrogen.cc - Issue 6306014: Fix reintroduction of global variables that have been deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 6306014: Fix reintroduction of global variables that have been deleted. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index dba2c17bbd859a663d05bfa1cb2b14f1358e1f90..53cf97ceb479eb54daccbceff411c45f3ece0394 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -3370,9 +3370,10 @@ void HGraphBuilder::HandleGlobalVariableAssignment(Variable* var,

LookupGlobalPropertyCell(var, &lookup, true);

CHECK_BAILOUT;

+ bool check_hole = !lookup.IsDontDelete() || lookup.IsReadOnly();

Handle<GlobalObject> global(graph()->info()->global_object());

Handle<JSGlobalPropertyCell> cell(global->GetPropertyCell(&lookup));

- HInstruction* instr = new HStoreGlobal(value, cell);

+ HInstruction* instr = new HStoreGlobal(value, cell, check_hole);

instr->set_position(position);

AddInstruction(instr);

if (instr->HasSideEffects()) AddSimulate(ast_id);

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »