Fix reintroduction of global variables that have been deleted.

src/arm/lithium-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1584 matching lines @@
 
 LInstruction* LChunkBuilder::DoLoadGlobal(HLoadGlobal* instr) {
   LLoadGlobal* result = new LLoadGlobal();
   return instr->check_hole_value()
       ? AssignEnvironment(DefineAsRegister(result))
       : DefineAsRegister(result);
 }
 
 
 LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) {
-  return new LStoreGlobal(UseRegisterAtStart(instr->value()));
+  LOperand* temp = instr->check_hole_value() ? TempRegister() : NULL;

[Kevin Millikin (Chromium), 2011/01/27 07:56:07]

OK, but since almost every line has to check the same flag, I'd split it into:

if (instr->check_hole_value()) {
  LOperand* temp = TempRegister();
  LOperand* value = UseRegister(instr->value());
  LStoreGlobal* result = new LStoreGlobal(value, temp);
  return AssignEnvironment(result);
} else {
  LOperand* value = UseRegisterAtStart(instr->value());
  return new LStoreGlobal(value, NULL);
}

[Mads Ager (chromium), 2011/01/27 08:33:36]

Done.

+  LOperand* value = instr->check_hole_value()
+      ? UseRegister(instr->value())
+      : UseRegisterAtStart(instr->value());
+  LStoreGlobal* result = new LStoreGlobal(value, temp);
+  return instr->check_hole_value() ? AssignEnvironment(result) : result;
 }
 
 
 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
   return DefineAsRegister(new LLoadContextSlot);
 }
 
 
 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
   return DefineAsRegister(
@@ skipping 243 matching lines @@
 
 
 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
   HEnvironment* outer = current_block_->last_environment()->outer();
   current_block_->UpdateEnvironment(outer);
   return NULL;
 }
 
 
 } }  // namespace v8::internal