Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 6306014: Fix reintroduction of global variables that have been deleted. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 1595
1596 LInstruction* LChunkBuilder::DoLoadGlobal(HLoadGlobal* instr) { 1596 LInstruction* LChunkBuilder::DoLoadGlobal(HLoadGlobal* instr) {
1597 LLoadGlobal* result = new LLoadGlobal(); 1597 LLoadGlobal* result = new LLoadGlobal();
1598 return instr->check_hole_value() 1598 return instr->check_hole_value()
1599 ? AssignEnvironment(DefineAsRegister(result)) 1599 ? AssignEnvironment(DefineAsRegister(result))
1600 : DefineAsRegister(result); 1600 : DefineAsRegister(result);
1601 } 1601 }
1602 1602
1603 1603
1604 LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) { 1604 LInstruction* LChunkBuilder::DoStoreGlobal(HStoreGlobal* instr) {
1605 return new LStoreGlobal(UseRegisterAtStart(instr->value())); 1605 if (instr->check_hole_value()) {
1606 LOperand* temp = TempRegister();
1607 LOperand* value = UseRegister(instr->value());
1608 return AssignEnvironment(new LStoreGlobal(value, temp));
1609 } else {
1610 LOperand* value = UseRegisterAtStart(instr->value());
1611 return new LStoreGlobal(value, NULL);
1612 }
1606 } 1613 }
1607 1614
1608 1615
1609 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1616 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1610 return DefineAsRegister(new LLoadContextSlot); 1617 return DefineAsRegister(new LLoadContextSlot);
1611 } 1618 }
1612 1619
1613 1620
1614 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) { 1621 LInstruction* LChunkBuilder::DoLoadNamedField(HLoadNamedField* instr) {
1615 return DefineAsRegister( 1622 return DefineAsRegister(
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
1859 1866
1860 1867
1861 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1868 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1862 HEnvironment* outer = current_block_->last_environment()->outer(); 1869 HEnvironment* outer = current_block_->last_environment()->outer();
1863 current_block_->UpdateEnvironment(outer); 1870 current_block_->UpdateEnvironment(outer);
1864 return NULL; 1871 return NULL;
1865 } 1872 }
1866 1873
1867 1874
1868 } } // namespace v8::internal 1875 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698