Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2317)

Unified Diff: chrome/browser/autocomplete/history_quick_provider.cc

Issue 6306011: Remove wstring from autocomplete. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_quick_provider.cc
===================================================================
--- chrome/browser/autocomplete/history_quick_provider.cc (revision 72388)
+++ chrome/browser/autocomplete/history_quick_provider.cc (working copy)
@@ -52,7 +52,7 @@
// NOTE: This purposefully doesn't take input.desired_tld() into account; if
// it did, then holding "ctrl" would change all the results from the
// HistoryQuickProvider provider, not just the What You Typed Result.
- const std::wstring fixed_text(FixupUserInput(input));
+ const string16 fixed_text(FixupUserInput(input));
if (fixed_text.empty()) {
// Conceivably fixup could result in an empty string (although I don't
// have cases where this happens offhand). We can't do anything with
@@ -76,7 +76,7 @@
void HistoryQuickProvider::DoAutocomplete() {
// Get the matching URLs from the DB.
- string16 term_string(WideToUTF16(autocomplete_input_.text()));
+ string16 term_string = autocomplete_input_.text();
term_string = UnescapeURLComponent(term_string,
UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS);
history::InMemoryURLIndex::String16Vector terms(
@@ -114,34 +114,33 @@
match_type == WHAT_YOU_TYPED ? std::string() : languages_;
match.fill_into_edit =
AutocompleteInput::FormattedStringWithEquivalentMeaning(info.url(),
- UTF16ToWide(net::FormatUrl(info.url(), languages, format_types,
- UnescapeRule::SPACES, NULL, NULL,
- &inline_autocomplete_offset)));
+ net::FormatUrl(info.url(), languages, format_types,
+ UnescapeRule::SPACES, NULL, NULL,
+ &inline_autocomplete_offset));
if (!autocomplete_input_.prevent_inline_autocomplete())
match.inline_autocomplete_offset = inline_autocomplete_offset;
- DCHECK((match.inline_autocomplete_offset == std::wstring::npos) ||
+ DCHECK((match.inline_autocomplete_offset == string16::npos) ||
(match.inline_autocomplete_offset <= match.fill_into_edit.length()));
size_t match_start = history_match.input_location;
- match.contents =
- UTF16ToWide(net::FormatUrl(info.url(), languages, format_types,
- UnescapeRule::SPACES, NULL, NULL,
- &match_start));
- if ((match_start != std::wstring::npos) &&
- (inline_autocomplete_offset != std::wstring::npos) &&
+ match.contents = net::FormatUrl(info.url(), languages, format_types,
+ UnescapeRule::SPACES, NULL, NULL,
+ &match_start);
+ if ((match_start != string16::npos) &&
+ (inline_autocomplete_offset != string16::npos) &&
(inline_autocomplete_offset != match_start)) {
DCHECK(inline_autocomplete_offset > match_start);
AutocompleteMatch::ClassifyLocationInString(match_start,
inline_autocomplete_offset - match_start, match.contents.length(),
ACMatchClassification::URL, &match.contents_class);
} else {
- AutocompleteMatch::ClassifyLocationInString(std::wstring::npos, 0,
+ AutocompleteMatch::ClassifyLocationInString(string16::npos, 0,
match.contents.length(), ACMatchClassification::URL,
&match.contents_class);
}
- match.description = UTF16ToWide(info.title());
+ match.description = info.title();
AutocompleteMatch::ClassifyMatchInString(autocomplete_input_.text(),
- UTF16ToWide(info.title()),
+ info.title(),
ACMatchClassification::NONE,
&match.description_class);

Powered by Google App Engine
This is Rietveld 408576698