BackgroundModeManager will no longer listen to EXTENSION_(UN)INSTALLED.

chrome/browser/background_mode_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/base_paths.h"
 #include "base/command_line.h"
@@ skipping 50 matching lines @@
     keep_alive_for_startup_ = true;
     BrowserList::StartKeepAlive();
   }
 
   // If the -keep-alive-for-test flag is passed, then always keep chrome running
   // in the background until the user explicitly terminates it, by acting as if
   // we loaded a background app.
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kKeepAliveForTest))
     OnBackgroundAppLoaded();
 
-  // When an extension is installed, make sure launch on startup is properly
-  // set if appropriate. Likewise, turn off launch on startup when the last
-  // background app is uninstalled.
-  registrar_.Add(this, NotificationType::EXTENSION_INSTALLED,
-                 Source<Profile>(profile));
-  registrar_.Add(this, NotificationType::EXTENSION_UNINSTALLED,
-                 Source<Profile>(profile));
   // Listen for when extensions are loaded/unloaded so we can track the
-  // number of background apps.
+  // number of background apps and modify our keep-alive and launch-on-startup
+  // state appropriately.
   registrar_.Add(this, NotificationType::EXTENSION_LOADED,
                  Source<Profile>(profile));
   registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,
                  Source<Profile>(profile));
 
   // Check for the presence of background apps after all extensions have been
   // loaded, to handle the case where an extension has been manually removed
   // while Chrome was not running.
   registrar_.Add(this, NotificationType::EXTENSIONS_READY,
                  Source<Profile>(profile));
@@ skipping 20 matching lines @@
                                     const NotificationSource& source,
                                     const NotificationDetails& details) {
   switch (type.value) {
     case NotificationType::EXTENSIONS_READY:
       // Extensions are loaded, so we don't need to manually keep the browser
       // process alive any more when running in no-startup-window mode.
       EndKeepAliveForStartup();
 
       // On a Mac, we use 'login items' mechanism which has user-facing UI so we
       // don't want to stomp on user choice every time we start and load
-      // registered extensions.
+      // registered extensions. This means that if a background app is removed
+      // or added while Chrome is not running, we could leave Chrome in the
+      // wrong state, but this is better than constantly forcing Chrome to
+      // launch on startup even after the user removes the LoginItem manually.
 #if !defined(OS_MACOSX)
       EnableLaunchOnStartup(background_app_count_ > 0);
 #endif
       break;
     case NotificationType::EXTENSION_LOADED:
       if (BackgroundApplicationListModel::IsBackgroundApp(
               *Details<Extension>(details).ptr())) {
+        // Extensions loaded after the ExtensionsService is ready should be
+        // treated as new installs.
+        if (profile_->GetExtensionService()->is_ready())
+          OnBackgroundAppInstalled();
         OnBackgroundAppLoaded();
       }
       break;
     case NotificationType::EXTENSION_UNLOADED:
       if (BackgroundApplicationListModel::IsBackgroundApp(
               *Details<UnloadedExtensionInfo>(details)->extension)) {
         OnBackgroundAppUnloaded();
-      }
-      break;
-    case NotificationType::EXTENSION_INSTALLED:
-      if (BackgroundApplicationListModel::IsBackgroundApp(
-              *Details<Extension>(details).ptr())) {
-        OnBackgroundAppInstalled();
-      }
-      break;
-    case NotificationType::EXTENSION_UNINSTALLED:
-      if (Extension::HasApiPermission(
-            Details<UninstalledExtensionInfo>(details).ptr()->
-                extension_api_permissions,
-            Extension::kBackgroundPermission)) {
         OnBackgroundAppUninstalled();
       }
       break;
     case NotificationType::APP_TERMINATING:
       // Make sure we aren't still keeping the app alive (only happens if we
       // don't receive an EXTENSIONS_READY notification for some reason).
       EndKeepAliveForStartup();
       // Performing an explicit shutdown, so exit background mode (does nothing
       // if we aren't in background mode currently).
       EndBackgroundMode();
@@ skipping 212 matching lines @@
   // is always running on that platform, making it superfluous.
 #if defined(OS_CHROMEOS)
   return false;
 #else
   bool background_mode_enabled =
       !command_line->HasSwitch(switches::kDisableBackgroundMode) &&
       !command_line->HasSwitch(switches::kDisableExtensions);
   return background_mode_enabled;
 #endif
 }