Issue 6306008: Collect GL_EXTENSIONS string in GPUInfo and display it in about:gpu page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6306008: Collect GL_EXTENSIONS string in GPUInfo and display it in about:gpu page.... (Closed)

Created:
9 years, 11 months ago by Zhenyao Mo

Modified:
9 years, 7 months ago

Reviewers:
zmo, greggman

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Collect GL_EXTENSIONS string in GPUInfo and display it in about:gpu page. BUG=none TEST=GL_EXTENSIONS showing in about:gpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72180

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -2 lines)			Patch
M	chrome/browser/dom_ui/gpu_internals_ui.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/gpu_info.h	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/gpu_info.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/common/gpu_info_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/gpu_messages.cc	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/gpu_messages_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/gpu/gpu_info_collector.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/gpu/gpu_info_collector_unittest.cc	View	5 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

greggman

LGTM Though that is one crappy system. GPUInfo should be redefined as std::map<std::string, std::string> Then ...

9 years, 11 months ago (2011-01-21 19:14:20 UTC) #2

zmo

9 years, 11 months ago (2011-01-21 19:16:38 UTC) #3

I totally agree with you.  Me and Nat talked about use DictionaryValue for this
for a while, but never got the time to do the refactoring...

On 2011/01/21 19:14:20, greggman wrote:
> LGTM
> 
> Though that is one crappy system. GPUInfo should be redefined as
> std::map<std::string, std::string> Then you'd only have to change 1 or 2 files
> to add stuff.

Expand Messages | Collapse Messages