Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 6306006: Make bookmark_utils::GetNameForURL return a string16. (Closed)

Created:
9 years, 11 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Make bookmark_utils::GetNameForURL return a string16. It is returning Unicode so it should be a string16. The callers want a string16 anyway. TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_bar_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_utils_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
I'm considering moving this function into the _gtk file, since it's only used by gtk. ...
9 years, 11 months ago (2011-01-20 23:26:19 UTC) #1
Evan Stade
seems ok to move it, but what do the other platforms do?
9 years, 11 months ago (2011-01-21 00:36:58 UTC) #2
Evan Martin
$ git gs IDS_APP_UNTITLED_SHORTCUT_FILE_NAME app/resources/app_strings.grd:191: <message name="IDS_APP_UNTITLED_SHORTCUT_FILE_NAME" desc="The name of the Internet Shortcut file created ...
9 years, 11 months ago (2011-01-21 00:38:27 UTC) #3
Evan Martin
I think I should submit this change regardless of code location. LGTY?
9 years, 11 months ago (2011-01-21 00:54:49 UTC) #4
Evan Stade
9 years, 11 months ago (2011-01-21 00:56:47 UTC) #5
ok, move away. LGTM either way.

Powered by Google App Engine
This is Rietveld 408576698