Issue 63054: Convert /third_party/ffmpeg to gyp and a python build script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63054: Convert /third_party/ffmpeg to gyp and a python build script. (Closed)

Created:
11 years, 8 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
bradn, sgk

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Convert /third_party/ffmpeg to gyp for Windows builds. To smooth out the transition I left in using_ffmpeg.vsprops until the rest of Windows switches over to gyp. I also took the opportunity to ditch the .bat file in favour of python.

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -236 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/media.gyp	View	4 chunks	+2 lines, -14 lines	0 comments	Download
A	third_party/ffmpeg/ffmpeg.gyp	View	1 chunk	+100 lines, -0 lines	0 comments	Download
M	third_party/ffmpeg/ffmpeg.vcproj	View	1 chunk	+0 lines, -196 lines	0 comments	Download
M	third_party/ffmpeg/generate_libs.bat	View	1 chunk	+0 lines, -8 lines	0 comments	Download
A	third_party/ffmpeg/generate_libs.py	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	third_party/ffmpeg/generate_libs.rules	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

This would be my first major gyp contribution.. hopefully I did it right :) It's ...

11 years, 8 months ago (2009-04-07 07:49:45 UTC) #1

sgk

11 years, 8 months ago (2009-04-07 22:06:19 UTC) #3

ffmpeg.gyp only does anything on Windows.  Is this going to be a multi-platform
in the future?  If not, then all of the other dependencies on ffmpeg.gyp should
be in OS=="win" conditionals so we don't generate useless build configurations
on the other systems.

Expand Messages | Collapse Messages