Modify devserver and gmerge to be friendlier

devserver.py

 #!/usr/bin/python
 
 # Copyright (c) 2009-2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A CherryPy-based webserver to host images and build packages."""
 
 import cherrypy
 import optparse
 import os
+import subprocess
 import sys
 
 import autoupdate
 
 CACHED_ENTRIES=12
 
 # Sets up global to share between classes.
 global updater
 updater = None
 
@@ skipping 40 matching lines @@
     if image_dir != os.readlink('static/archive'):
       cherrypy.log('removing stale symlink to %s' % image_dir, 'DEVSERVER')
       os.unlink('static/archive')
       os.symlink(image_dir, 'static/archive')
   else:
     os.symlink(image_dir, 'static/archive')
   cherrypy.log('archive dir: %s ready to be used to serve images.' % image_dir,
                'DEVSERVER')
 
 
-class DevServerRoot:
+def _OutputOf(command):
+  """Runs command, a list of arguments beginning with an executable.
+
+  If the executable begins with "scripts/", the path is adjusted to
+  the scripts directory of this chroot.
+
+  Args:
+    A list of arguments, beginning with the executable
+  Returns:
+    A list of lines returned by the command
+"""
+

[sosa, 2011/01/14 23:03:54]

Don't need this extra line

[rochberg, 2011/01/15 06:16:48]

Done.

+  scripts = 'scripts/'
+  if command[0].find(scripts) == 0:
+    command[0] = command[0].replace(scripts, '../../' + scripts)
+  cherrypy.log('Executing: ' + ' '.join(command), 'BUILD')
+  output_blob = subprocess.Popen(command,
+                                 stdout=subprocess.PIPE).communicate()[0]
+  return [line.rstrip() for line in output_blob.split('\n')]
+

[sosa, 2011/01/14 23:03:54]

2 lines between top level defs

+def _IsIn(needle, haystack_list):

[sosa, 2011/01/14 23:03:54]

Isn't this equivalent to needle in haystick_list?

I just tried with 
a="""tacos are super
delicious taco t
blake"""

"taco" in a = True
"blake" in a = True
"alskdjgasljkg" in a = False

[rochberg, 2011/01/15 06:16:48]

The way the code is structured now, the relevant test would be
"taco" in [a], which is False.  But we don't make any use of the line-oriented
nature of the output, so I'll switch to just plain "in" and the raw output

+  for line in haystack_list:
+    if needle in line:
+      return True
+  return False
+

[sosa, 2011/01/14 23:03:54]

2 lines between top level defs

[rochberg, 2011/01/15 06:16:48]

Done.

+class Builder(object):

[sosa, 2011/01/14 23:03:54]

Should probably move this into its own module.

[rochberg, 2011/01/15 06:16:48]

Done.

+  def _ShouldBeWorkedOn(self, board, pkg):
+    """Is pkg a package that could be worked on, but is not?"""
+    if _IsIn(pkg, _OutputOf([
+        'scripts/cros_workon', '--board=' + board, 'list'])):
+      return False
+
+    # If it's in the list of possible workon targets, we should be working on it
+    return _IsIn(pkg, _OutputOf([
+        'scripts/cros_workon', '--board=' + board, 'list', '--all']))
+
+  def SetError(self, text):
+    cherrypy.response.status = 500
+    cherrypy.log(text, 'BUILD')
+    return text
+
+  def Build(self, board, pkg, additional_args):
+    cherrypy.log('Additional build request arguments: '+ str(additional_args),
+                 'BUILD')
+
+    original_use = os.environ.get('USE', '')
+    if 'use' in additional_args:
+      os.environ['USE'] = original_use + ' ' + additional_args['use']
+      cherrypy.log("USE flags modified to " + os.environ['USE'], 'BUILD')
+
+    try:
+      if (self._ShouldBeWorkedOn(board, pkg) and
+          not additional_args.get('accept_stable')):
+        return self.SetError(
+            'Package is not cros_workon\'d on the devserver machine.\n'
+            'Either start working on the package or pass --accept_stable '
+            'to gmerge')
+
+      rc = subprocess.call(['emerge-%s' % board, pkg])
+      if rc != 0:
+        return self.SetError('Could not emerge ' + pkg)
+
+      cherrypy.log('ecleaning %s' % pkg, 'BUILD')
+      rc = subprocess.call(['eclean-' + board,  '-d', 'packages'])
+      if rc != 0:
+        return self.SetError('eclean failed')
+
+      cherrypy.log('eclean complete %s' % pkg, 'BUILD')
+      return 'Success\n'
+
+    except OSError, e:
+      return self.SetError('Could not execute build command: ' + str(e))
+
+    finally:
+      os.environ['USE'] =  original_use
+
+
+class DevServerRoot(object):
   """The Root Class for the Dev Server.
 
   CherryPy works as follows:
     For each method in this class, cherrpy interprets root/path
     as a call to an instance of DevServerRoot->method_name.  For example,
     a call to http://myhost/build will call build.  CherryPy automatically
     parses http args and places them as keyword arguments in each method.
     For paths http://myhost/update/dir1/dir2, you can use *args so that
     cherrypy uses the update method and puts the extra paths in args.
   """
 
-  def build(self, board, pkg):
+  def __init__(self):
+    self._builder = Builder()
+
+  def build(self, board, pkg, **kwargs):
     """Builds the package specified."""
-    cherrypy.log('emerging %s' % pkg, 'BUILD')
-    emerge_command = 'emerge-%s %s' % (board, pkg)
-    err = os.system(emerge_command)
-    if err != 0:
-      raise Exception('failed to execute %s' % emerge_command)
-    eclean_command = 'eclean-%s -d packages' % board
-    err = os.system(eclean_command)
-    if err != 0:
-      raise Exception('failed to execute %s' % emerge_command)
+    return self._builder.Build(board, pkg, kwargs)
 
   def index(self):
     return 'Welcome to the Dev Server!'
 
   def update(self, *args):
     label = '/'.join(args)
     body_length = int(cherrypy.request.headers['Content-Length'])
     data = cherrypy.request.rfile.read(body_length)
     return updater.HandleUpdatePing(data, label)
 
@@ skipping 103 matching lines @@
     # We don't run the dev server with this option.
     if options.validate_factory_config:
       sys.exit(0)
   elif options.pregenerate_update:
     if not updater.PreGenerateUpdate():
       sys.exit(1)
 
   # If the command line requested after setup, it's time to do it.
   if not options.exit:
     cherrypy.quickstart(DevServerRoot(), config=_GetConfig(options))