Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 6305002: AU: Add options to delta_generator to hash and sign generated payloads. (Closed)

Created:
9 years, 11 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr, gauravsh, Raja Aluri, scottz
Visibility:
Public.

Description

AU: Add options to delta_generator to hash and sign generated payloads. To generate a SHA-256 hash for signing an unsigned payload use: ./delta_generator -in_file <unsigned_payload> \ -out_hash_file <hash_for_signing> -signature_size <size> To add a signature to an unsigned payload use: ./delta_generator -in_file <unsigned_payload> \ -signature_file <signature> -out_file <signed_payload> The size of the signature file must be exactly the same as the signature size supplied while hashing the payload. Also removed the -apply_delta option because it's replaced by the new -in_file option -- if -in_file is specified with no other hashing/signing option, the generator runs in delta application mode. BUG=chromium-os:10872 TEST=manually ran delta_generator on payloads Change-Id: Ie918239a4db607153932cc1907127790cf3179d3 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=da8c136

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -44 lines) Patch
M generate_delta_main.cc View 1 4 chunks +92 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
petkov
In a subsequent CL I'll try to include the delta_generator in some unit tests.
9 years, 11 months ago (2011-01-13 19:53:40 UTC) #1
petkov
9 years, 11 months ago (2011-01-13 19:54:27 UTC) #2
adlr
LGTM in the future it would probably be good to have a verify option where ...
9 years, 11 months ago (2011-01-13 20:42:37 UTC) #3
petkov
9 years, 11 months ago (2011-01-13 20:47:34 UTC) #4
Yes, that's exactly what I was planning to do -- add a verify option and use a
full hash/sign/verify cycle in a unit test.

I'll push this CL as is though -- it should enable the build team to add payload
signing to the release build.

http://codereview.chromium.org/6305002/diff/1/generate_delta_main.cc
File generate_delta_main.cc (right):

http://codereview.chromium.org/6305002/diff/1/generate_delta_main.cc#newcode30
generate_delta_main.cc:30: "Directory where the old rootfs is loop mounted
read-only.");
On 2011/01/13 20:42:37, adlr wrote:
> be consistent w/ adding a period to the end of help messages

Done.

Powered by Google App Engine
This is Rietveld 408576698