Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 63047: Revert "Initial implemention of Mac Omnibox." (Closed)

Created:
11 years, 8 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1028 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +0 lines, -309 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.h View 1 chunk +0 lines, -97 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 1 chunk +0 lines, -248 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.h View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +0 lines, -120 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.mm View 9 chunks +72 lines, -24 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Scott Hess - ex-Googler
Not sure how much good it will do. ui_tests work with or without this on ...
11 years, 8 months ago (2009-04-07 04:45:02 UTC) #1
Scott Hess - ex-Googler
On 2009/04/07 04:45:02, shess wrote: > Not sure how much good it will do. ui_tests ...
11 years, 8 months ago (2009-04-07 04:51:14 UTC) #2
Scott Hess - ex-Googler
Say - anyone else awake out there? I ran a build through the try-server both ...
11 years, 8 months ago (2009-04-07 05:01:29 UTC) #3
Scott Hess - ex-Googler
On 2009/04/07 05:01:29, shess wrote: > Say - anyone else awake out there? I ran ...
11 years, 8 months ago (2009-04-07 05:21:19 UTC) #4
Nicolas Sylvain
11 years, 8 months ago (2009-04-07 14:58:57 UTC) #5
lgtm, thanks.

For a revert, or anything that fixes the tree, you can send the review but you
don't have to wait for the LGTM, just submit it TBR.

Nicolas

Powered by Google App Engine
This is Rietveld 408576698