Issue 63045: "Save page as..." disregarded the specified file path, because the result of ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63045: "Save page as..." disregarded the specified file path, because the result of ... (Closed)

Created:
11 years, 8 months ago by Roland

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), sky1

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

"Save page as..." disregarded the specified file path, because the result of the "Save As" dialog got written to a temporary and then discarded. Changed code to use a explicit variable to pass file path in and out of SaveFileAsWithFilter() (Did not find a relevant bug entry for this).

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/views/shell_dialogs_win.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Roland

Found the issue found while trying to get to grips with code base (still new ...

11 years, 8 months ago (2009-04-07 02:17:27 UTC) #1

Roland

On 2009/04/07 03:59:16, Avi wrote: > D'oh! That's correct. LGTM. Hi Avi, I don't yet ...

11 years, 8 months ago (2009-04-07 17:34:01 UTC) #3

Roland

11 years, 8 months ago (2009-04-07 18:04:04 UTC) #5

On 2009/04/07 17:48:07, Avi wrote:
> Committed r13260.

Thanks a lot!

Roland

Expand Messages | Collapse Messages