Issue 6304021: [Sync] Remove now-obsolete FastDump class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6304021: [Sync] Remove now-obsolete FastDump class (Closed)

Created:
9 years, 11 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Remove now-obsolete FastDump class Fix uses of bare 'string' to be 'std::string'. BUG=55816 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72559

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -156 lines)			Patch
M	chrome/browser/sync/engine/process_commit_response_command.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_proto_util_unittest.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View	4 chunks	+15 lines, -50 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_id.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_id.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/browser/sync/util/fast_dump.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	chrome/browser/sync/util/user_settings_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/sync/engine/mock_connection_manager.h	View	7 chunks	+25 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM. Presumably logging code is not actually run when logging is turned off? (i.e. logging ...

9 years, 11 months ago (2011-01-25 21:05:31 UTC) #2

akalin

9 years, 11 months ago (2011-01-25 21:13:42 UTC) #3

On 2011/01/25 21:05:31, nzea wrote:
> LGTM.
> 
> Presumably logging code is not actually run when logging is turned off? (i.e.
> logging code has no performance impact in default release mode)

Yes, that's correct.

Expand Messages | Collapse Messages