Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 6304016: Fix bad assumption in object literal interpretation. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix bad assumption in object literal interpretation. We allow symbols that are array indices. Committed: http://code.google.com/p/v8/source/detail?r=6447

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/ast.cc View 1 chunk +11 lines, -4 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 11 months ago (2011-01-24 14:06:46 UTC) #1
fschneider
LGTM. http://codereview.chromium.org/6304016/diff/1/src/ast.cc File src/ast.cc (right): http://codereview.chromium.org/6304016/diff/1/src/ast.cc#newcode240 src/ast.cc:240: void* key; Could this be made an Object** ...
9 years, 11 months ago (2011-01-24 14:47:52 UTC) #2
Lasse Reichstein
9 years, 11 months ago (2011-01-25 07:48:12 UTC) #3
http://codereview.chromium.org/6304016/diff/1/src/ast.cc
File src/ast.cc (right):

http://codereview.chromium.org/6304016/diff/1/src/ast.cc#newcode240
src/ast.cc:240: void* key;
Not without some reinterpret-casts.
There isn't a simple conversion from String** (which is what this location()
returns) or Smi** to Object**. The use of the value is in table->Lookup which
expects a void*.

Powered by Google App Engine
This is Rietveld 408576698