Second attempt to work around App Engine flakiness by retrying upon URLError...

Second attempt to work around App Engine flakiness by retrying upon URLError
("Connection timed out"). This allowed me to successfully upload a CL I had
been stuck on for a couple of hours.

Manually tested by raising both HTTPError and URLError within this code block
and ensuring both are caught correctly.

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71702

[Ken Russell (switch to Gerrit), 2011-01-15 04:06:59]

Please re-review; thanks.

Note that this new except block is below that handling HTTPError, not above as
in my last CL, and is also more robust in case a different URLError subclass is
thrown.

[M-A Ruel, 2011-01-17 18:17:17]

http://codereview.chromium.org/6304006/diff/1/third_party/upload.py
File third_party/upload.py (right):

http://codereview.chromium.org/6304006/diff/1/third_party/upload.py#newcode420
third_party/upload.py:420: if hasattr(e, 'reason'):
you could rewrite as
reason = getattr(e, 'reason', None)
and continue with line 422.

[Ken Russell (switch to Gerrit), 2011-01-18 21:24:10]

http://codereview.chromium.org/6304006/diff/1/third_party/upload.py
File third_party/upload.py (right):

http://codereview.chromium.org/6304006/diff/1/third_party/upload.py#newcode420
third_party/upload.py:420: if hasattr(e, 'reason'):
On 2011/01/17 18:17:17, Marc-Antoine Ruel wrote:
> you could rewrite as
> reason = getattr(e, 'reason', None)
> and continue with line 422.

Done.

[M-A Ruel, 2011-01-18 21:36:02]

lgtm