Issue 6303017: Fix input-speech related failures on DRT...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6303017: Fix input-speech related failures on DRT... (Closed)

Created:
9 years, 11 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
tony, Satish

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix input-speech related failures on DRT Windows and Mac implementations lacked IDR_INPUT_SPEECH* handling. This change fixes them by removing resource ID checking. TEST=Some of LayoutTests/fast/speech/. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72581

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -41 lines)			Patch
	M	webkit/support/platform_support_mac.mm	View	1	1 chunk	+3 lines, -21 lines	0 comments	Download
	M	webkit/support/platform_support_win.cc	View	1	2 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/6303017/diff/1/webkit/support/platform_support_win.cc File webkit/support/platform_support_win.cc (right): http://codereview.chromium.org/6303017/diff/1/webkit/support/platform_support_win.cc#newcode104 webkit/support/platform_support_win.cc:104: return NetResourceProvider(resource_id); Nit: Can we rename this function ...

9 years, 11 months ago (2011-01-25 17:24:44 UTC) #3

tkent

9 years, 11 months ago (2011-01-26 01:11:53 UTC) #4

Satish, Tony, thank you for reviewing.
I'll commit this with the NetResourceProvider change.

http://codereview.chromium.org/6303017/diff/1/webkit/support/platform_support...
File webkit/support/platform_support_win.cc (right):

http://codereview.chromium.org/6303017/diff/1/webkit/support/platform_support...
webkit/support/platform_support_win.cc:104: return
NetResourceProvider(resource_id);
On 2011/01/25 17:24:44, tony wrote:
> Nit: Can we rename this function to ResourceProvider (since some of these are
> not net resources)?

Done.

Expand Messages | Collapse Messages