Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 6303013: Fix Smi::IsValid assert in StringCharCodeAt deferred code. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix Smi::IsValid assert in StringCharCodeAt deferred code. Committed: http://code.google.com/p/v8/source/detail?r=6424

Patch Set 1 #

Total comments: 1

Patch Set 2 : Made Mads happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +17 lines, -4 lines 0 comments Download
M test/mjsunit/string-charcodeat.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 11 months ago (2011-01-20 14:55:06 UTC) #1
Mads Ager (chromium)
http://codereview.chromium.org/6303013/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6303013/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2758 src/ia32/lithium-codegen-ia32.cc:2758: if (!Smi::IsValid(const_index)) { We shouldn't generate code at all ...
9 years, 11 months ago (2011-01-20 15:03:17 UTC) #2
Mads Ager (chromium)
9 years, 11 months ago (2011-01-21 07:08:18 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698