Issue 6303013: Fix Smi::IsValid assert in StringCharCodeAt deferred code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6303013: Fix Smi::IsValid assert in StringCharCodeAt deferred code. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix Smi::IsValid assert in StringCharCodeAt deferred code. Committed: http://code.google.com/p/v8/source/detail?r=6424

Patch Set 2 : Made Mads happy #

Created: 9 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -8 lines)
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+16 lines, -4 lines	0 comments
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+17 lines, -4 lines	0 comments
M	test/mjsunit/string-charcodeat.js	View	1 chunk	+11 lines, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

http://codereview.chromium.org/6303013/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6303013/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2758 src/ia32/lithium-codegen-ia32.cc:2758: if (!Smi::IsValid(const_index)) { We shouldn't generate code at all ...

9 years, 11 months ago (2011-01-20 15:03:17 UTC) #2

LGTM!

Expand Messages | Collapse Messages

Issue 6303013: Fix Smi::IsValid assert in StringCharCodeAt deferred code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Made Mads happy #

Messages