Issue 63029: Clarify the documentation for loading_only on TabRenderer::UpdateData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63029: Clarify the documentation for loading_only on TabRenderer::UpdateData. (Closed)

Created:
11 years, 8 months ago by brettw at google

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clarify the documentation for loading_only on TabRenderer::UpdateData.

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	chrome/browser/tabs/tab_strip_model.h	View		2 chunks	+11 lines, -0 lines	2 comments	Download
	M	chrome/browser/views/tabs/tab_renderer.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM. http://codereview.chromium.org/63029/diff/1003/1005 File chrome/browser/tabs/tab_strip_model.h (right): http://codereview.chromium.org/63029/diff/1003/1005#newcode80 Line 80: // specified. If other things change, set ...

11 years, 8 months ago (2009-04-07 13:29:27 UTC) #3

brettw

11 years, 8 months ago (2009-04-07 16:59:31 UTC) #4

http://codereview.chromium.org/63029/diff/1003/1005
File chrome/browser/tabs/tab_strip_model.h (right):

http://codereview.chromium.org/63029/diff/1003/1005#newcode80
Line 80: // specified. If other things change, set this flag to false to update
I think that comments should generally be written from the perspective of the
caller. You're looking at this as the implementor, but in the future, there will
be people looking at the comment from both the caller's and the implementor's
perspective.

I will add a little more clarification about what should happen.

Expand Messages | Collapse Messages

Issue 63029: Clarify the documentation for loading_only on TabRenderer::UpdateData. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages