Issue 63022: Layout the tabs explicitly when creating a background tab. Update to correct ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63022: Layout the tabs explicitly when creating a background tab. Update to correct ... (Closed)

Created:
11 years, 8 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Layout the tabs explicitly when creating a background tab. Update to correct tab model observer API so we once again get update messages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13249

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -13 lines)			Patch
M	chrome/browser/cocoa/tab_strip_controller.mm	View	6 chunks	+20 lines, -11 lines	2 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm http://codereview.chromium.org/63022/diff/1002/3 File chrome/browser/cocoa/tab_strip_controller.mm (right): http://codereview.chromium.org/63022/diff/1002/3#newcode290 Line 290: // [self swapInTabAtIndex:index]; why commented out?

11 years, 8 months ago (2009-04-06 20:08:12 UTC) #2

pink (ping after 24hrs)

11 years, 8 months ago (2009-04-06 20:13:46 UTC) #3

http://codereview.chromium.org/63022/diff/1002/3
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/63022/diff/1002/3#newcode290
Line 290: // [self swapInTabAtIndex:index];
On 2009/04/06 20:08:12, TVL wrote:
> why commented out?

oops, removing that code entirely.

Expand Messages | Collapse Messages