Adjustments in chrome_test_suite external dns lookups detection code:

Adjustments in chrome_test_suite external dns lookups detection code:

- allow resolving local hostname
- simulate a failing lookup of "wpad" in in_process_browser_test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13239

[Paweł Hajdan Jr., 2009-04-06 18:53:10]

Please test whether it fixes the problem from your last email.

If you still notice some lookups of wpad, I'll make the scope of
AddSimulatedFailure broader.

[Finnur, 2009-04-06 19:32:42]

This seems to work now. I ran the unit test for Find and the failures no longer
show up.

LGTM with two nits (don't need to review again).

http://codereview.chromium.org/63019/diff/1/2
File chrome/test/in_process_browser_test.cc (right):

http://codereview.chromium.org/63019/diff/1/2#newcode121
Line 121: // We don't want to depend on it in test code.
nit: depend? Is that the right word to use here?

http://codereview.chromium.org/63019/diff/1/3
File chrome/test/unit/chrome_test_suite.h (right):

http://codereview.chromium.org/63019/diff/1/3#newcode43
Line 43: local = true;
nit: This you can do before the for loop and put the for loop inside the
else-block of this if-statement.