Issue 6301005: Fix autocomplete for Gmail subject lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6301005: Fix autocomplete for Gmail subject lines. (Closed)

Created:
9 years, 11 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, James Hawkins, Ilya Sherman, dhollowa, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix autocomplete for Gmail subject lines. BUG=68626 TEST=Try to bring up autocomplete for the subject field of the Gmail "compose" view. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71720

Patch Set 1 #

Total comments: 1

Patch Set 2 : No logging #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/renderer/autofill_helper.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhollowa

9 years, 11 months ago (2011-01-14 16:13:28 UTC) #2

LGTM.  Minus logging.

http://codereview.chromium.org/6301005/diff/1/chrome/renderer/autofill_helper.cc
File chrome/renderer/autofill_helper.cc (right):

http://codereview.chromium.org/6301005/diff/1/chrome/renderer/autofill_helper...
chrome/renderer/autofill_helper.cc:282: GURL url =
node.document().frame()->url();
As tempting as this logging may be, there are privacy implications.  We need to
take this out.

Expand Messages | Collapse Messages