Issue 6301001: Add function for setting breakpoint by scriptId and position to debugger script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6301001: Add function for setting breakpoint by scriptId and position to debugger script (Closed)

Created:
9 years, 11 months ago by podivilov

Modified:
9 years, 3 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add function for setting breakpoint by scriptId and position to debugger script Committed: http://code.google.com/p/v8/source/detail?r=6302

Patch Set 2 : Fix style. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
	M	src/debug-debugger.js	View	1	5 chunks	+24 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM, but the function is not used anywhere. http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js#newcode653 src/debug-debugger.js:653: Debug.setBreakPointByScriptIdAndPosition ...

9 years, 11 months ago (2011-01-13 15:46:14 UTC) #2

podivilov

9 years, 11 months ago (2011-01-13 17:32:58 UTC) #3

On 2011/01/13 15:46:14, Søren Gjesse wrote:
> LGTM, but the function is not used anywhere.

It will be used from WebCore DebuggerScript.js

Expand Messages | Collapse Messages

Issue 6301001: Add function for setting breakpoint by scriptId and position to debugger script (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix style. #

Messages