Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: test/mjsunit/indexed-accessors.js

Issue 63010: Fix crash with indexed setter on objects without corresponding getter. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 assertEquals(1, a.length); 91 assertEquals(1, a.length);
92 a[5] = 42; 92 a[5] = 42;
93 assertEquals(0, b); 93 assertEquals(0, b);
94 assertEquals(42, a[5]); 94 assertEquals(42, a[5]);
95 assertEquals(6, a.length); 95 assertEquals(6, a.length);
96 96
97 // Using a setter where only a getter is defined throws an exception. 97 // Using a setter where only a getter is defined throws an exception.
98 var q = {}; 98 var q = {};
99 q.__defineGetter__('0', function() { return 42; }); 99 q.__defineGetter__('0', function() { return 42; });
100 assertThrows('q[0] = 7'); 100 assertThrows('q[0] = 7');
101
102 // Using a getter where only a setter is defined returns undefined.
103 var q1 = {};
104 q1.__defineSetter__('0', function() {q1.b = 17;});
105 assertEquals(q1[0], undefined);
106 // Setter works
107 q1[0] = 3;
108 assertEquals(q1[0], undefined);
109 assertEquals(q1.b, 17);
110
111 // Complex case of using an undefined getter.
112 // From http://code.google.com/p/v8/issues/detail?id=298
113 // Reported by nth10sd.
114
115 a = function() {};
116 __defineSetter__("0", function() {});
117 if (a |= '') {};
118 assertThrows('this[a].__parent__');
119 assertEquals(a, 0);
120 assertEquals(this[a], undefined);
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698