Issue 63010: Fix crash with indexed setter on objects without corresponding getter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63010: Fix crash with indexed setter on objects without corresponding getter. (Closed)

Created:
11 years, 8 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix crash with indexed setter on objects without corresponding getter. Committed: http://code.google.com/p/v8/source/detail?r=1678

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	src/objects.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	test/mjsunit/indexed-accessors.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 8 months ago (2009-04-06 14:34:11 UTC) #2

LGTM!

http://codereview.chromium.org/63010/diff/1/3
File src/objects.cc (right):

http://codereview.chromium.org/63010/diff/1/3#newcode5524
Line 5524: } else {
Perhaps add the comment "// Getter is not a function." (same as for the named
property case).

http://codereview.chromium.org/63010/diff/1/2
File test/mjsunit/indexed-accessors.js (right):

http://codereview.chromium.org/63010/diff/1/2#newcode117
Line 117: if(a|= ''){}
Please add space on both sides of the '('.

Expand Messages | Collapse Messages