Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 63006: Changing v8_shell to v8_shell_sample to match what the buildbot expects. (Closed)

Created:
11 years, 8 months ago by bradn
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Changing v8_shell to v8_shell_sample to match what the buildbot expects. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13146

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/temp_gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bradn
Ideally product_name would be used, but this feature is not implemented on windows. Since there ...
11 years, 8 months ago (2009-04-06 02:42:27 UTC) #1
bradn
Property changes on: build\temp_gyp ___________________________________________________________________ Modified: svn:ignore - googleurl.xcodeproj v8.xcodeproj googleurl_unittests.vcproj v8_shell_arm.vcproj v8_shell.vcproj v8.sln mksnapshot.vcproj ...
11 years, 8 months ago (2009-04-06 03:12:12 UTC) #2
bradn
Gonna submit this TBR to make the chromium release full xp build unred.
11 years, 8 months ago (2009-04-06 03:13:29 UTC) #3
Mark Mentovai
11 years, 8 months ago (2009-04-06 03:25:20 UTC) #4
This does not look good.

Please fix what the buildbots expect, or alternatively, as a temporary measure,
make this change conditional on Windows only.

Powered by Google App Engine
This is Rietveld 408576698