Rename ContentSettingsProviderInterface to DefaultContentSettingsProviderInterface.

Rename ContentSettingsProviderInterface to DefaultContentSettingsProviderInterface.

BUG=70750
TEST=content_settings_provider_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72503

[markusheintz_, 2011-01-25 12:52:17]

Pls review.

[Bernhard Bauer, 2011-01-25 12:56:57]

On 2011/01/25 12:52:17, markusheintz_ wrote:
> Pls review.

LGTM as soon as lint is happy.

[markusheintz_, 2011-01-25 13:03:53]

Fixed nit

[Bernhard Bauer, 2011-01-25 13:11:19]

Also, you could update the copyright date (it's not a big issue, though).

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.cc:96:
const_provider_iterator;
I guess you could pull out some more typedefs (ptr, vector) just to make it a
bit more readable.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/mock_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/mock_content_settings_provider.h:12: class
MockContentSettingsProvider :
Lint nits still apply (see
http://codereview.chromium.org/lint_patch/issue6300015_11001_12003)

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/policy_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/policy_content_settings_provider.h:23: class
PolicyContentSettingsProvider :
Same here.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/pref_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/pref_content_settings_provider.h:24: public
DefaultContentSettingsProviderInterface,
And here.

[jochen (gone - plz use gerrit), 2011-01-25 13:18:47]

nice!

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.h:233:
content_settings_providers_;
please rename this to default_content_settings_provider_

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/mock_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/mock_content_settings_provider.h:10: #include
"chrome/browser/content_settings/default_content_settings_provider.h"
i would not rename the header but put both interfaces in there

http://codereview.chromium.org/6300015/diff/11001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:814:
'browser/content_settings/default_content_settings_provider.h',
file does not exist?

[markusheintz_, 2011-01-25 13:57:43]

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.cc:96:
const_provider_iterator;
On 2011/01/25 13:11:19, Bernhard Bauer wrote:
> I guess you could pull out some more typedefs (ptr, vector) just to make it a
> bit more readable.
done.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/mock_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/mock_content_settings_provider.h:10: #include
"chrome/browser/content_settings/default_content_settings_provider.h"
On 2011/01/25 13:18:47, jochen wrote:
> i would not rename the header but put both interfaces in there

Done.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/mock_content_settings_provider.h:12: class
MockContentSettingsProvider :
On 2011/01/25 13:11:19, Bernhard Bauer wrote:
> Lint nits still apply (see
> http://codereview.chromium.org/lint_patch/issue6300015_11001_12003)

Done.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/policy_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/policy_content_settings_provider.h:23: class
PolicyContentSettingsProvider :
On 2011/01/25 13:11:19, Bernhard Bauer wrote:
> Same here.

Done.

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
File chrome/browser/content_settings/pref_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/browser/content_sett...
chrome/browser/content_settings/pref_content_settings_provider.h:24: public
DefaultContentSettingsProviderInterface,
On 2011/01/25 13:11:19, Bernhard Bauer wrote:
> And here.

Done.

http://codereview.chromium.org/6300015/diff/11001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/6300015/diff/11001/chrome/chrome_browser.gypi#...
chrome/chrome_browser.gypi:814:
'browser/content_settings/default_content_settings_provider.h',
On 2011/01/25 13:18:47, jochen wrote:
> file does not exist?

obsolete now. there will be no such file anymore

[jochen (gone - plz use gerrit), 2011-01-25 14:31:54]

some last nits

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.cc:116:
linked_ptr<DefaultContentSettingsProvider>(
DefaultContentSettingsProviderPtr

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.h (right):

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.h:233:
content_settings_providers_;
please rename this to default_content_settings_provider_

[markusheintz_, 2011-01-25 14:46:22]

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.cc:116:
linked_ptr<DefaultContentSettingsProvider>(
On 2011/01/25 14:31:55, jochen wrote:
> DefaultContentSettingsProviderPtr

Done.

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.h (right):

http://codereview.chromium.org/6300015/diff/18002/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.h:233:
content_settings_providers_;
On 2011/01/25 14:31:55, jochen wrote:
> please rename this to default_content_settings_provider_

This is already in the last previous patchset set. forgot to include in the one
before it.

[jochen (gone - plz use gerrit), 2011-01-25 14:52:47]

and now the year numbers got lost again...

LGTM given trybot happiness

http://codereview.chromium.org/6300015/diff/15002/chrome/browser/content_sett...
File chrome/browser/content_settings/host_content_settings_map.h (right):

http://codereview.chromium.org/6300015/diff/15002/chrome/browser/content_sett...
chrome/browser/content_settings/host_content_settings_map.h:1: // Copyright (c)
2010 The Chromium Authors. All rights reserved.
nit 2011

http://codereview.chromium.org/6300015/diff/15002/chrome/browser/content_sett...
File chrome/browser/content_settings/mock_content_settings_provider.h (right):

http://codereview.chromium.org/6300015/diff/15002/chrome/browser/content_sett...
chrome/browser/content_settings/mock_content_settings_provider.h:1: // Copyright
(c) 2010 The Chromium Authors. All rights reserved.
nit 2011