Issue 6300011: Only close the sync socket if it is non-NULL. This fixes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6300011: Only close the sync socket if it is non-NULL. This fixes... (Closed)

Created:
9 years, 11 months ago by nfullagar

Modified:
9 years, 7 months ago

Reviewers:
dmichael(do not use this one), brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Only close the sync socket if it is non-NULL. This fixes a NaCl page reload / surf-away regression. BUG=NaCl ppapi audio proxy TEST=native_client/tests/ppapi_example_audio Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72099

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ppapi/shared_impl/audio_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Ah, I just fixed an almost identical bug in audio_impl.cc. Sorry I missed this part. ...

9 years, 11 months ago (2011-01-21 03:29:50 UTC) #3

thx, committed as r72099

Expand Messages | Collapse Messages