Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6712)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 6300001: Clang: enable -Wbool-conversions and -Wunused-variables on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting fix Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/message_loop_unittest.cc ('K') | « base/pr_time_unittest.cc ('k') | ceee/ie/broker/cookie_api_module_unittest.cc » ('j') | net/base/cert_database_nss_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 1adb1722fa06df2d260ddc0585c11212ff7fcaaa..a61d36bc3176bbd69d501a96b99600266e9166f3 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1136,13 +1136,8 @@
}],
['clang==1', {
'cflags': [
- # Don't warn about unused variables, due to a common pattern:
- # scoped_deleter unused_variable(&thing_to_delete);
- '-Wno-unused-variable',
# Clang spots more unused functions.
'-Wno-unused-function',
- # gtest confuses clang.
- '-Wno-bool-conversions',
# Don't die on dtoa code that uses a char as an array index.
'-Wno-char-subscripts',
# Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
« base/message_loop_unittest.cc ('K') | « base/pr_time_unittest.cc ('k') | ceee/ie/broker/cookie_api_module_unittest.cc » ('j') | net/base/cert_database_nss_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698