Issue 6299025: dmazzoni's fixes to ALSA for speech_synthesis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6299025: dmazzoni's fixes to ALSA for speech_synthesis (Closed)

Created:
9 years, 11 months ago by davejcool

Modified:
9 years, 7 months ago

Reviewers:
zhurunz1, Chaitanya, dmazzoni, scherkus (not reviewing)

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/speech_synthesis.git@master

Visibility:
Public.

dmazzoni's fixes to ALSA After this change, speech_synthesis will not require PulseAudio in order to function. Change-Id: I051e8ed0f46bde1058dfc606f3e60cfbc41e7d41 BUG=chromium-os:8954, chromium-os:11321 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=88febc0

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -79 lines)			Patch
	M	linux/audio_output_alsa.cc	View		3 chunks	+80 lines, -74 lines	0 comments	Download
	M	tts_service.cc	View		3 chunks	+12 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

davejcool

LGTM. I also ran the patch and verified speech continued after suspend/resume while simultaneously playing ...

9 years, 11 months ago (2011-01-29 01:40:53 UTC) #1

dmazzoni

9 years, 10 months ago (2011-01-31 04:21:37 UTC) #2

LGTM.

Thanks for your help figuring this out and committing this for us!