Issue 6299017: Add --enable-nacl to the list of infobar-generating flags....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6299017: Add --enable-nacl to the list of infobar-generating flags.... (Closed)

Created:
9 years, 11 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
noelallen_use_chromium, Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add --enable-nacl to the list of infobar-generating flags. For M10, we don't want folks to turn on NaCl persistently because its API surface hasn't been vetted as thoroughly as we would like. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72560

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/ui/browser_init.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/6299017/diff/1/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/6299017/diff/1/chrome/browser/ui/browser_init.cc#newcode937 chrome/browser/ui/browser_init.cc:937: // These are scary features for developers that shouldn't ...

9 years, 11 months ago (2011-01-25 21:12:52 UTC) #3

abarth-chromium

9 years, 11 months ago (2011-01-25 21:16:18 UTC) #4

On Tue, Jan 25, 2011 at 1:12 PM,  <avi@chromium.org> wrote:
>
>
http://codereview.chromium.org/6299017/diff/1/chrome/browser/ui/browser_init.cc
> File chrome/browser/ui/browser_init.cc (right):
>
>
http://codereview.chromium.org/6299017/diff/1/chrome/browser/ui/browser_init....
> chrome/browser/ui/browser_init.cc:937: // These are scary features for
> developers that shouldn't be turn on
> grammar drive-by: turned on

Thanks!

Expand Messages | Collapse Messages