Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 6299011: DOMUI Prefs: Small style fixes for Basics page. (Closed)

Created:
9 years, 11 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI Prefs: Small style fixes for Basics page. - Adds spacing under the header on all subpages (preventing, e.g., lists from abutting the header underline) - Aligns the "Add" button to the left edge of the list above it, and adds space between the two. - Fixes the left-side padding of the new <select> style. BUG=None TEST=Spacing on startup page manager subpage should be better. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/options/browser_options_page.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
9 years, 11 months ago (2011-01-19 23:16:12 UTC) #1
James Hawkins
Would you mind enumerating what each part of the change does (visually) in the CL ...
9 years, 11 months ago (2011-01-19 23:21:48 UTC) #2
stuartmorgan
On 2011/01/19 23:21:48, James Hawkins wrote: > Would you mind enumerating what each part of ...
9 years, 11 months ago (2011-01-19 23:24:59 UTC) #3
James Hawkins
On 2011/01/19 23:24:59, stuartmorgan wrote: > On 2011/01/19 23:21:48, James Hawkins wrote: > > Would ...
9 years, 11 months ago (2011-01-19 23:31:04 UTC) #4
stuartmorgan
9 years, 11 months ago (2011-01-19 23:38:47 UTC) #5
On 2011/01/19 23:31:04, James Hawkins wrote:
> LGTM, but I think we need to change div.page > h3 { margin } to be 10,0,10,0
to
> offset.

Margins collapse, so that's not necessary.

Powered by Google App Engine
This is Rietveld 408576698