Reload plugin options from user's preferences after login

Reload plugin options from user's preferences after login

Previously PluginService::InitGlobalInstance was called only from BrowserMain i.e. before user profile is mounted. This change adds options reload when user profile is available. I checked boot times are not affected by this change.

BUG=chromium-os:7556
TEST=Manual, see issue

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71938

[Dmitry Polukhin, 2011-01-19 08:55:22]

Dave, please take a look to this CL. I don't know who can review such change. I
hope you can review it or at least know who can do it.

[DaveMoore, 2011-01-19 18:26:24]

This looks ok to me, but I'd like one of the people who worked on the
InitGlobalInstance() code to comment on whether it's ok to reinitialize it. Note
to them: on cros we change the profile upon login. There's never more than one
active profile at the same time. One profile is used while the login panel is
displayed and a second one is used after login. No plugins are loaded before the
switch. Upon logout we close down the browser.

[Dmitry Polukhin, 2011-01-20 08:38:36]

Please take a look to this CL.

[Bernhard Bauer, 2011-01-20 09:37:15]

On 2011/01/19 18:26:24, davemoore wrote:
> This looks ok to me, but I'd like one of the people who worked on the
> InitGlobalInstance() code to comment on whether it's ok to reinitialize it.
Note
> to them: on cros we change the profile upon login. There's never more than one
> active profile at the same time. One profile is used while the login panel is
> displayed and a second one is used after login. No plugins are loaded before
the
> switch. Upon logout we close down the browser.

As in closing the browser object or terminating the browser process? We should
watch out for stuff like disabling certain plugins from one profile, then
disabling other plugins *in addition* from another profile (after a logout-login
as another user), as PluginUpdater::DisableGroupsFromPrefs assumes that all
plugins are enabled beforehand and only disables plugins.

OTOH, I have no idea about the login/logout process, so if that's taken care of,
cool :)

http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
chrome/browser/chromeos/login/login_utils.cc:312:
PluginService::InitGlobalInstance(profile);
I'm a bit wary about calling an Init method more than once. If it's just about
setting the correct enabled/disabled state, could you just call

  PluginUpdater::GetInstance()->DisableGroupsFromPrefs(profile)

directly?

[Dmitry Polukhin, 2011-01-20 09:58:44]

Chrome process is restarted. So it is not disabling something in addition to
previous state. Without my change all plugins are enable for each new login.

http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
chrome/browser/chromeos/login/login_utils.cc:312:
PluginService::InitGlobalInstance(profile);
On 2011/01/20 09:37:15, Bernhard Bauer wrote:
> I'm a bit wary about calling an Init method more than once. If it's just about
> setting the correct enabled/disabled state, could you just call
> 
>   PluginUpdater::GetInstance()->DisableGroupsFromPrefs(profile)
> 
> directly?

Done.

[Bernhard Bauer, 2011-01-20 09:59:48]

On 2011/01/20 09:58:44, Dmitry Polukhin wrote:
> Chrome process is restarted. So it is not disabling something in addition to
> previous state. Without my change all plugins are enable for each new login.
> 
>
http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
> File chrome/browser/chromeos/login/login_utils.cc (right):
> 
>
http://codereview.chromium.org/6299010/diff/1/chrome/browser/chromeos/login/l...
> chrome/browser/chromeos/login/login_utils.cc:312:
> PluginService::InitGlobalInstance(profile);
> On 2011/01/20 09:37:15, Bernhard Bauer wrote:
> > I'm a bit wary about calling an Init method more than once. If it's just
about
> > setting the correct enabled/disabled state, could you just call
> > 
> >   PluginUpdater::GetInstance()->DisableGroupsFromPrefs(profile)
> > 
> > directly?
> 
> Done.

Great, LGTM then.