Issue 6299008: chrome/browser/ui/views include ordering and (C) dates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6299008: chrome/browser/ui/views include ordering and (C) dates (Closed)

Created:
9 years, 11 months ago by msw

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update the include ordering and (C) dates. Affects files that include from chrome/browser/ui/views BUG=69082 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71561

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	chrome/browser/ui/views/accessible_pane_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/appcache_info_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/clear_server_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_prompt2.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_root_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/info_bubble.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_infobar_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/content_page_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/passwords_exceptions_window_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 11 months ago (2011-01-15 19:22:20 UTC) #2

LG

If you haven't used it, this kind of thing is best done using
tools/sort-headers.py (and if you're renaming files, you want to look at
tools/git/mass-rename.sh as well).


Nit: The TEST= line is intended for qa testing, saying "TEST=unittests" doesn't
help them. Better say TEST=none.

Expand Messages | Collapse Messages