Syntax checker for policy_templates.json

ceee/PRESUBMIT.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import os
 import sys
 
 
 def CheckChange(input_api, output_api, committing):
   # We need to change the path so that we can import ceee_presubmit
   # which lies at the root of the ceee folder. And we do it here so that
   # it doesn't pollute all the cases where we get imported yet not called.
-  sys.path.append(os.path.join(input_api.PresubmitLocalPath(), '../ceee'))
-  import ceee_presubmit
-  return ceee_presubmit.CheckChange(input_api,
-                                    output_api,
-                                    committing)
+  old_sys_path = sys.path
+  try:
+    sys.path = ([input_api.os_path.join(input_api.PresubmitLocalPath(),

[M-A Ruel, 2011/01/18 16:06:23]

nit: I think you should create a named variable since it's hard to read.

[Jakob Kummerow, 2011/01/18 16:33:54]

Done.

+                                        '../ceee')] +
+                sys.path)
+    import ceee_presubmit
+    result = ceee_presubmit.CheckChange(input_api,

[M-A Ruel, 2011/01/18 16:06:23]

you can return here, the finally clause will still be correctly executed.

[Jakob Kummerow, 2011/01/18 16:33:54]

Done.

+                                        output_api,
+                                        committing)
+  finally:
+    sys.path = old_sys_path
+  return result
+
 
 
 def CheckChangeOnUpload(input_api, output_api):
   return CheckChange(input_api, output_api, False)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   return CheckChange(input_api, output_api, True)