Syntax checker for policy_templates.json

chrome/app/policy/PRESUBMIT.py

+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# If this presubmit check fails or misbehaves, please complain to
+# gfeher@chromium.org or jkummerow@chromium.org.
+
+import sys
+import traceback
+
+
+def _CommonChecks(input_api, output_api):
+  filename = 'policy_templates.json'
+  results = []
+  for f in input_api.AffectedFiles():
+    if (f.AbsoluteLocalPath() ==
+            input_api.os_path.join(input_api.PresubmitLocalPath(), filename)):
+      old_sys_path = sys.path
+      try:

[M-A Ruel, 2011/01/18 15:10:33]

BTW, you can move the sys.path mangling outside of the loop since
input_api.PresubmitLocalPath() is invariant throughout this function. It would
make the code more readable too.

[Jakob Kummerow, 2011/01/18 15:51:28]

Done.

+        sys.path = [input_api.PresubmitLocalPath()] + sys.path
+        # Optimization: only load this when it's needed.
+        import syntax_check_policy_template_json
+        checker = syntax_check_policy_template_json.PolicyTemplateChecker()
+        result = checker.Run([], f.AbsoluteLocalPath())
+        if result > 0:
+          results.append(output_api.PresubmitError(
+              'Syntax error(s) in file:', [f]))
+      finally:
+        sys.path = old_sys_path
+  return results
+
+
+def CheckChangeOnUpload(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+  return _CommonChecks(input_api, output_api)