Issue 6298011: O2D: Implement the COPY_WITH_FADING paint operator, and change some of the ot...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6298011: O2D: Implement the COPY_WITH_FADING paint operator, and change some of the ot... (Closed)

Created:
9 years, 11 months ago by Tristan Schmelcher 2

Modified:
9 years, 6 months ago

Reviewers:
zhurunz1, geer, fbarchard, Tim H

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

O2D: Implement the COPY_WITH_FADING paint operator, and change some of the other code to be simpler. TEST=loaded O2D and verified COPY_WITH_FADING works BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72194

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
	M	core/cross/cairo/renderer_cairo.cc	View	1	4 chunks	+28 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fbarchard

http://codereview.chromium.org/6298011/diff/1/core/cross/cairo/renderer_cairo.cc File core/cross/cairo/renderer_cairo.cc (right): http://codereview.chromium.org/6298011/diff/1/core/cross/cairo/renderer_cairo.cc#newcode151 core/cross/cairo/renderer_cairo.cc:151: // but surprisingly that is slightly slower for me ...

9 years, 11 months ago (2011-01-21 02:25:59 UTC) #3

Tristan Schmelcher 2

9 years, 11 months ago (2011-01-21 18:31:29 UTC) #4

http://codereview.chromium.org/6298011/diff/1/core/cross/cairo/renderer_cairo.cc
File core/cross/cairo/renderer_cairo.cc (right):

http://codereview.chromium.org/6298011/diff/1/core/cross/cairo/renderer_cairo...
core/cross/cairo/renderer_cairo.cc:151: // but surprisingly that is slightly
slower for me ...
On 2011/01/21 02:26:00, fbarchard wrote:
> comment should not say 'me' or people will wonder who said that.
> can add a todo or note, or just reword.

Done.

Expand Messages | Collapse Messages